feat(redis): support data_collection option - #6960
Merged
Merged
Conversation
Gate inclusion of non-key Redis command arguments in span descriptions and pipeline command data behind the data_collection.database_query_data option, which takes precedence over send_default_pii when set. When the option is disabled, non-key arguments are omitted from the command description; when unset, it defaults to enabled. Add test coverage for the enabled/disabled/default cases, precedence over send_default_pii, and the pipeline path. Refs PY-2587 Refs #6747
ericapisani
changed the title
ericapisani
marked this pull request as ready for review
July 30, 2026 14:07
alexander-alderman-webb
approved these changes
Jul 30, 2026
Contributor
Codecov Results 📊✅ 99501 passed | ⏭️ 6733 skipped | Total: 106234 | Pass Rate: 93.66% | Execution Time: 350m 33s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2496 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.89% 89.89% —%
==========================================
Files 193 193 —
Lines 24681 24686 +5
Branches 8810 8814 +4
==========================================
+ Hits 22185 22190 +5
- Misses 2496 2496 —
- Partials 1398 1398 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate inclusion of non-key Redis command arguments in span descriptions and pipeline command data behind the
data_collection.database_query_dataoption, which takes precedence oversend_default_piiwhen set. When the option is disabled, non-key arguments are omitted from the command description; when unset, it defaults to enabled.Adds test coverage for the enabled/disabled/default cases, precedence over
send_default_pii, and the pipeline path.Refs PY-2587